From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
Cc: | PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Fixing pgbench's logging of transaction timestamps |
Date: | 2017-01-02 17:28:31 |
Message-ID: | 20259.1483378111@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
I wrote:
> BTW, why is it that the --aggregate-interval option is unsupported on
> Windows? Is that an artifact of the same disease of assuming too much
> about how instr_time is represented? I don't see any very good reason
> for it other than the weird decision to store the result of
> INSTR_TIME_GET_DOUBLE in a "long", which seems rather broken in any case.
After looking closer, I see the real issue is that it prints the integer
part of INSTR_TIME_GET_DOUBLE and documents that as being a Unix
timestamp. So that's not going to do either. I solved it the same way
as in the other code path, ie just eat the cost of doing our own time
inquiry.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Jim Nasby | 2017-01-02 17:30:40 | Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal |
Previous Message | Jim Nasby | 2017-01-02 17:13:28 | Re: Odd behavior with PG_TRY |