dispchar for oauth_client_secret

From: Noah Misch <noah(at)leadboat(dot)com>
To: jacob(dot)champion(at)enterprisedb(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: dispchar for oauth_client_secret
Date: 2025-04-15 19:14:35
Message-ID: 20250415191435.55.nmisch@google.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

commit b3f0be7 wrote:
+ {"oauth_scope", NULL, NULL, NULL,
+ "OAuth-Scope", "", 15,
+ offsetof(struct pg_conn, oauth_scope)},

The field containing "" is documented as follows:

char *dispchar; /* Indicates how to display this field in a
* connect dialog. Values are: "" Display
* entered value as is "*" Password field -
* hide value "D" Debug option - don't show
* by default */

I suspect this should use .dispchar="*" to encourage UIs to display
oauth_client_secret like a password field. Thoughts?

[I didn't review commit b3f0be7, but this caught my attention.]

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2025-04-15 19:21:33 Re: [PoC] Federated Authn/z with OAUTHBEARER
Previous Message Alvaro Herrera 2025-04-15 19:11:49 Re: not null constraints, again