| From: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Mahendra Singh Thalor <mahi6run(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Non text modes for pg_dumpall, correspondingly change pg_restore |
| Date: | 2025-04-14 12:20:10 |
| Message-ID: | 202504141220.343fmoxfsbj4@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 2025-Apr-04, Andrew Dunstan wrote:
> Non text modes for pg_dumpall, correspondingly change pg_restore
I think the new oid_string_list stuff in this commit is unnecessary, and
we can remove a bunch of lines by simplifying that to using
SimplePtrList, as the attached illustrates. (Perhaps the names of
members of the proposed struct can be improved.)
I also propose to remove the open-coded implementation of pg_get_line.
WDYT?
I'm also not sure about the double sscanf() business there ... There
must be a better way to do this.
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-remove-unnecessary-oid_string-list-stuff.patch | text/x-diff | 12.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2025-04-14 14:03:28 | Re: pgsql: Add function to get memory context stats for processes |
| Previous Message | Peter Eisentraut | 2025-04-14 06:57:44 | pgsql: Fix incorrect format placeholders |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matheus Alcantara | 2025-04-14 12:25:11 | Re: New committer: Jacob Champion |
| Previous Message | Kirill Reshke | 2025-04-14 12:05:25 | Re: support create index on virtual generated column. |