Re: Restrict publishing of partitioned table with a foreign table as partition

From: Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Sergey Tatarintsev <s(dot)tatarintsev(at)postgrespro(dot)ru>
Cc: Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Restrict publishing of partitioned table with a foreign table as partition
Date: 2025-04-07 12:30:59
Message-ID: 202504071230.2dw72naygjvf@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2025-Apr-07, Sergey Tatarintsev wrote:

> I think this is a wrong assumption:
>
> ScanKeyInit(&key[keycount++], Anum_pg_class_relispartition,
> BTEqualStrategyNumber, F_BOOLEQ, BoolGetDatum(false));
>
> In this case sch5.part1 is partitioned table, but it also partition of table
> in different schema

Yeah, this looks ill-considered.

After looking at this code some more, I'm withdrawing myself from here.
(I don't mean just this patch in particular, I mean the logical
replication code as a whole.)

Thanks,

--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"La persona que no quería pecar / estaba obligada a sentarse
en duras y empinadas sillas / desprovistas, por cierto
de blandos atenuantes" (Patricio Vogel)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Álvaro Herrera 2025-04-07 12:39:23 Re: Restrict publishing of partitioned table with a foreign table as partition
Previous Message Mahendra Singh Thalor 2025-04-07 12:25:54 as per commit 643a1a61985bef2590496, move create/open dir code to function using switch case of pg_backup_directory.c file also