Quote-less file names in error messages

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Quote-less file names in error messages
Date: 2025-04-04 03:03:28
Message-ID: 20250404.120328.103562371975971823.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello,

The recent commit 2da74d8d640 added the following new messages:

+ libpq_append_conn_error(conn, "could not open ssl keylog file %s: %s",
+ libpq_append_conn_error(conn, "could not write to ssl keylog file %s: %s

However, I believe our convention is to quote file names in such messages.

The attached patch 0001 fixes this issue.

While working on this, I found a few other instances of the same
issue:

- A WARNING message in `fd.c` seems worth fixing (0002).

- Two DEBUG2 messages in `xlog.c` seem less important to fix (0003).

- I don't think it's worth bothering with those in developer tools (0004).

Please find the attached patches.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

Attachment Content-Type Size
0001-Quote-file-names-in-recently-introduced-error-messag.patch text/x-patch 1.4 KB
0002-Quote-file-names-in-an-exising-WARNING-message.patch text/x-patch 930 bytes
0003-Quote-file-names-in-existing-DEBUG2-messages.patch text/x-patch 1.3 KB
0004-Quote-file-names-in-developer-tool-messages.patch text/x-patch 2.5 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Hayato Kuroda (Fujitsu) 2025-04-04 03:06:02 RE: Some codes refer slot()->{'slot_name'} but it is not defined
Previous Message Richard Guo 2025-04-04 02:53:54 Re: Removing unneeded self joins