Question about comments on simple_heap_update

From: Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Question about comments on simple_heap_update
Date: 2025-03-31 11:44:02
Message-ID: 20250331204402.784a75f11c38aa9b6c0accc0@sraoss.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

While working on [1], I found the internal error "tuple concurrently updated"
is raised by simple_heap_update and other similar functions, and the comments
on them says "Any failure is reported via ereport()". However, I could not understand
the intension of this comments because I suppose the unexpected errors are usual
reported via elog() not ereport and in fact elog() is used in these functions.

I wonder this statement should be fixed as the attached patch or could be removed for
less confusion. Maybe, I am just missing something, though....

[1] https://www.postgresql.org/message-id/flat/20250331200057.00a62760966a821d484ea904%40sraoss.co.jp

--
Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>

Attachment Content-Type Size
fix_comments_on_siple_heap_update.patch text/x-diff 2.0 KB

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2025-03-31 11:48:30 Add partial :-variable expansion to psql \copy
Previous Message Michael Paquier 2025-03-31 11:43:22 Re: per backend WAL statistics