Re: simplifying grammar for ALTER CONSTRAINT .. SET [NO] INHERIT

From: Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Suraj Kharage <suraj(dot)kharage(at)enterprisedb(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: simplifying grammar for ALTER CONSTRAINT .. SET [NO] INHERIT
Date: 2025-03-27 08:27:00
Message-ID: 202503270827.g6ofbwsgjlcw@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2025-Mar-26, Suraj Kharage wrote:

> Yes, I agree. As Peter said, it is now inline with other commands.
>
> I have reviewed the patch and it looks good to me.

Thanks for reviewing!

> Since we are removing the SET keyword, how about removing that from the
> below comment as well.
>
> /*
> * Propagate the change to children. For SET NO INHERIT, we don't
> * recursively affect children, just the immediate level.
> */
>
> This is the comment from ATExecAlterConstrInheritability().

Ah right. Fixed that and pushed.

--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message John Naylor 2025-03-27 08:31:27 Re: [PATCH] SVE popcount support
Previous Message Dmitrii Bondar 2025-03-27 08:13:12 Re: [fixed] Trigger test