| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Antonin Houska <ah(at)cybertec(dot)at>, pgsql-hackers(at)postgresql(dot)org, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Robert Haas <robertmhaas(at)gmail(dot)com>, Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
| Subject: | Re: AIO v2.5 |
| Date: | 2025-03-25 22:44:40 |
| Message-ID: | 20250325224440.0f.nmisch@google.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 25, 2025 at 04:56:53PM -0400, Andres Freund wrote:
> The repeated-iteration approach taken in pgaio_closing_fd() isn't the
> prettiest, but it's hard to to imagine that ever being a noticeable.
Yep. I've reviewed the fixup code, and it looks all good.
> This survives a testrun where I use your torture patch and where I force all
> IOs to use ASYNC. Previously that did not get very far. I also did verify
> that, if I allow a small number of FDs, we do not wrongly wait for all IOs.
I, too, see the test diffs gone.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2025-03-25 22:56:50 | Re: Query ID Calculation Fix for DISTINCT / ORDER BY and LIMIT / OFFSET |
| Previous Message | Thomas Munro | 2025-03-25 21:39:44 | Re: Cannot find a working 64-bit integer type on Illumos |