Re: Doc: fix the rewrite condition when executing ALTER TABLE ADD COLUMN

From: Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: jian he <jian(dot)universality(at)gmail(dot)com>
Cc: Masahiro Ikeda <ikedamsh(at)oss(dot)nttdata(dot)com>, Robert Treat <rob(at)xzilla(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Doc: fix the rewrite condition when executing ALTER TABLE ADD COLUMN
Date: 2025-03-24 10:37:20
Message-ID: 202503241037.pjpyt5j7xrfs@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2025-Mar-24, jian he wrote:

> In the current development branch,
> virtual generated columns still do not support the domain.
> you can not change the generation expression if it contains a check
> constraint on it.
> so virtual generated columns don't need rewriting.
>
> IMHO, the committed doc description didn't mention this exception.
> we need some text to cover this exception?

I'd add a note about these two things to the open items page, and wait
to see if we get some of these limitations fixed, so that if we don't,
we remember to note this limitation in the documentation.

--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"All rings of power are equal,
But some rings of power are more equal than others."
(George Orwell's The Lord of the Rings)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Yura Sokolov 2025-03-24 10:41:17 Re: sinvaladt.c: remove msgnumLock, use atomic operations on maxMsgNum
Previous Message Vincent Moreau 2025-03-24 10:27:05 [PATCH] Add a new pattern for zero-based months for Date/Time Formatting