| From: | Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Amul Sul <sulamul(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Subject: | Re: bogus error message for ALTER TABLE ALTER CONSTRAINT |
| Date: | 2025-03-14 11:16:43 |
| Message-ID: | 202503141116.4dt3o344svkd@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2025-Mar-11, Amul Sul wrote:
> I was thinking of something like the attached, which includes your
> test cases from 0001. Perhaps the macro name could be improved.
FWIW I like this general idea. I don't like the proposed names much
though, especially the abuse of ALL_CAPS; and because they operate on
the given bits themselves rather than the output of processCASbits(), I
would have these checks before doing anything else. (Also, for nicer
code layout I would perhaps make the macros static inline functions.)
I'm going to stay away from this for a bit, as I think this is of
somewhat secondary importance.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"Every machine is a smoke machine if you operate it wrong enough."
https://twitter.com/libseybieda/status/1541673325781196801
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2025-03-14 12:06:25 | Re: Reducing memory consumed by RestrictInfo list translations in partitionwise join planning |
| Previous Message | Heikki Linnakangas | 2025-03-14 11:16:42 | Re: Optimization for lower(), upper(), casefold() functions. |