Re: pgsql: reindexdb: Add the index-level REINDEX with multiple jobs

From: Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Alexander Korotkov <akorotkov(at)postgresql(dot)org>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Maxim Orlov <orlovmg(at)gmail(dot)com>, Svetlana Derevyanko <s(dot)derevyanko(at)postgrespro(dot)ru>
Subject: Re: pgsql: reindexdb: Add the index-level REINDEX with multiple jobs
Date: 2025-03-08 09:56:55
Message-ID: 202503080956.vjxmabdkatan@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 2025-Mar-07, Álvaro Herrera wrote:

> I tested this, because of a refactoring suggestion [1] and I find that
> it's rather completely broken.

I think we need significantly more complex scheduling code if we want
this to actually work, possibly even having to hack the ParallelSlot
API some, so that we can inspect which tables have a running reindex and
know not to schedule the next one on it. What we're doing now makes no
sense.

We should strike this out from the list of features of 17 and revert
this commit.

If we want this feature in 19, we need another go through the drawing
board. (There's clearly not enough time to do it for 18.)

--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alexander Korotkov 2025-03-08 10:42:41 Re: pgsql: reindexdb: Add the index-level REINDEX with multiple jobs
Previous Message Peter Eisentraut 2025-03-08 08:45:07 Re: pgsql: Generalize hash and ordering support in amapi

Browse pgsql-hackers by date

  From Date Subject
Next Message jian he 2025-03-08 10:10:56 Re: support virtual generated column not null constraint
Previous Message Michail Nikolaev 2025-03-08 09:51:45 Re: Why does exec_simple_query requires 2 snapshots