Re: pgsql: Consolidate docs for vacuum-related GUCs in new subsection

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Melanie Plageman <melanieplageman(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Consolidate docs for vacuum-related GUCs in new subsection
Date: 2025-01-13 20:46:40
Message-ID: 202501132046.m4mcvxxswznu@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 2025-Jan-13, Melanie Plageman wrote:

> Since I didn't hear back about this and I don't see an obvious
> alternative reorganization in guc_tables.c, I plan to just push the
> attached patch that updates only postgresql.conf.sample.

Apologies, I was very unclear -- I didn't want to talk about the
ordering of entries in the code, but the categorization. See the
config_group_names list in guc_tables.c, which defines some groups.
Each setting belongs into a group, and those groups correspond to what
the sample config file lists as section/subsection titles and to the
grouping in the docs. Also, this categorization affects how the entries
are listed in the pg_settings view and in "postgres --describe-config",
which feed from the same tables.

Perhaps with your changes (assuming I read your commit message right),
we need new groups:
VACUUMING
VACUUMING_FREEZING
VACUUMING_AUTOVACUUM

Thanks

--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"Doing what he did amounts to sticking his fingers under the hood of the
implementation; if he gets his fingers burnt, it's his problem." (Tom Lane)

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Jeff Davis 2025-01-13 22:19:11 pgsql: Revert "TupleHashTable: store additional data along with tuple."
Previous Message Melanie Plageman 2025-01-13 20:22:11 pgsql: Reorder vacuum GUCs in postgresql.conf.sample to match docs

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Treat 2025-01-13 21:22:09 Re: Question about behavior of deletes with REPLICA IDENTITY NOTHING
Previous Message Robert Haas 2025-01-13 20:43:46 Re: AIO v2.2