| From: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Refactor WinGetFuncArgInFrame |
| Date: | 2025-01-06 07:31:07 |
| Message-ID: | 20250106.163107.1264903753591492603.ishii@postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
While working on this:
https://www.postgresql.org/message-id/20230625.210509.1276733411677577841.t-ishii%40sranhm.sra.co.jp
I noticed that WinGetFuncArgInFrame() in nodeWindowAgg.c is hard to
read/understand. I think part of the reason is, it is long and has
large switch case and uses goto. I propose to refactor the function to
mitigate the issue. With attached patch, the large switch case is
moved to a new static function WinGetSlotInFrame().
Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Refactor-WinGetFuncArgInFrame.patch | application/octet-stream | 3.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2025-01-06 07:58:36 | Re: Re: proposal: schema variables |
| Previous Message | Masahiro Ikeda | 2025-01-06 07:17:32 | Re: Doc: clarify the log message level of the VERBOSE option |