Re: psql: Add leakproof field to \dAo+ meta-command results

From: Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>
To: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
Cc: Erik Wienhold <ewie(at)ewie(dot)name>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: psql: Add leakproof field to \dAo+ meta-command results
Date: 2024-12-04 11:20:57
Message-ID: 20241204202057.2e5693eff71bef5e5e653329@sraoss.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 15 Nov 2024 17:26:08 +0000
Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> wrote:

> On Fri, 15 Nov 2024 at 09:55, Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> wrote:
> >
> > I'll fixed the patch to add leakproof info to \do+ results, but is it worth
> > leaving this info in \dAo+ results, too?
> >
>
> I suppose that might still be useful in some contexts.
>
> Looking through the complete list of psql meta-commands, "leakproof"
> could plausibly be added to the output of each of the following:
>
> \dAo+
> \dC+
> \df+
> \do+

I've attached a updated patch (v3-0001) that include changes on all
of these meta-commands.

>
> > > I notice that this patch spells "leakproof" with a hyphen. IMO
> > > leakproof should not have a hyphen -- at least, that's how I naturally
> > > spell it, and I think that's more common, and it matches the SQL
> > > syntax.
> >
> > OK, I'll fix it to use "leakproof" without a hyphen.
> >
> > > We haven't been consistent about that in the docs and code comments so
> > > far though, so I think we should make a decision, and then standardise
> > > on whatever people decide.
> >
> > I am not a native English speaker, but if this is natural spelling in
> > English, I wonder we can replace all of them to leakproof without a hyphen.
> >
>
> Yes, I think we should do that (in a separate patch).

And, the patch v3-0002 is for that.

Regards,
Yugo Nagata

--
Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>

Attachment Content-Type Size
v3-0002-Doc-replace-leak-proof-in-documents-and-comments-.patch text/x-diff 5.5 KB
v3-0001-psql-Add-leakproof-field-to-dAo-meta-command-resu.patch text/x-diff 19.1 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nazir Bilal Yavuz 2024-12-04 11:29:00 Re: Make pg_stat_io view count IOs as bytes instead of blocks
Previous Message Peter Eisentraut 2024-12-04 11:15:40 Re: SQL:2011 application time