Re: Fix array access (src/bin/pg_dump/pg_dump.c)

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix array access (src/bin/pg_dump/pg_dump.c)
Date: 2024-11-12 19:11:07
Message-ID: 202411121911.3vwdrzfgjt4o@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2024-Nov-12, Ranier Vilela wrote:

> Per Coverity.
>
> The function *determineNotNullFlags* has a little oversight.
> The struct field *notnull_islocal* is an array.
>
> I think this is a simple typo.
> Fix using array notation access.

Yeah, thanks, I had been made aware of this bug. Before fixing I'd like
to construct a test case that tickles that code, because it's currently
uncovered *shudder*

--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"Find a bug in a program, and fix it, and the program will work today.
Show the program how to find and fix a bug, and the program
will work forever" (Oliver Silfridge)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2024-11-12 19:18:30 Re: pg_rewind WAL segments deletion pitfall
Previous Message Andres Freund 2024-11-12 17:45:35 Re: Commit Timestamp and LSN Inversion issue