Re: Fix for Extra Parenthesis in pgbench progress message

> On 2024/11/08 11:47, Tatsuo Ishii wrote:
>> I think you need to adjust
>> fprintf(stderr, "%*c\r", chars - 1, ' '); /* Clear the current line */
>> to:
>> fprintf(stderr, "%*c\r", chars, ' '); /* Clear the current line */
>> since now chars does not consider the EOL char. By clearing chars - 1,
>> the closing parenthesis will be left on the screen.
>
> You're right! I've updated the patch and attached v4.

V4 patch looks good to me.

> About the back-patch: initially, there were concerns it might be too
> invasive,
> as you told upthread. However, after our discussion, I think the
> latest version
> is straightforward enough, and I'm okay with back-patching
> it. Thoughts?

I agree. Now the patch is small enough to back-patch.

> Since the minor release freeze is already in effect, if we commit this
> patch,
> we'll need to wait until the next minor releases are out next week
> before
> the commit and back-patch.

Got it.
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp