| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Tender Wang <tndrwang(at)gmail(dot)com> |
| Cc: | Alexander Lakhin <exclusion(at)gmail(dot)com>, Jehan-Guillaume de Rorthais <jgdr(at)dalibo(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
| Subject: | Re: [BUG] Fix DETACH with FK pointing to a partitioned table fails |
| Date: | 2024-10-26 19:28:54 |
| Message-ID: | 202410261928.cnrvrjbzx63y@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2024-Oct-25, Tender Wang wrote:
> When I debug codes, I find that the way to access AttrMap almost uses
> "attrmp_ptr->attnums[offset]."
> The codes now usually don't check if the offset is out of bounds, which
> seems unsafe.
> Can we wrap an access function? For example:
> inline AttrNumber(attrmap_ptr, offset)
> {
> Assert(offset >= 0 && offset < attrmap_ptr->maplen);
> return attrmap_ptr->attnums[offset];
> }
I don't see any reason not to do this, though it's not directly related
to the bugs in this thread. I encourage you to submit a patch, opening
a new thread.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2024-10-26 21:18:35 | Re: Fix C23 compiler warning |
| Previous Message | Stepan Neretin | 2024-10-26 19:12:48 | Re: Assertion failure when autovacuum drops orphan temp indexes. |