From: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
---|---|
To: | dgrowleyml(at)gmail(dot)com |
Cc: | ashutosh(dot)bapat(dot)oss(at)gmail(dot)com, orlovmg(at)gmail(dot)com, jian(dot)universality(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Add memory/disk usage for WindowAgg nodes in EXPLAIN |
Date: | 2024-09-19 00:01:34 |
Message-ID: | 20240919.090134.1961749747398456709.ishii@postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On Thu, 19 Sept 2024 at 00:13, Tatsuo Ishii <ishii(at)postgresql(dot)org> wrote:
>> Actually there's one more executor node type that uses tuplestore:
>> recursive union (used in "with recursive"). The particular node type
>> uses two tuplestore and we cannot simply apply tuplestore_get_stats()
>> to the node type. We need to modify RecursiveUnionState to track the
>> maximum tuplestore usage. I am not sure this would be worth the
>> effort. Opinion?
>
> Could you add the two sizes together and take the storage type from
> the tuplestore with the highest storage size?
I don't think this works because tuplestore_begin/tuplestore_end are
called while executing the node (ExecRecursiveUnion).
I think the way you are proposing only shows the stats last time when
those tuplestore are created.
Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
From | Date | Subject | |
---|---|---|---|
Next Message | Andy Fan | 2024-09-19 00:03:38 | Re: detoast datum into the given buffer as a optimization. |
Previous Message | Masahiko Sawada | 2024-09-18 23:53:27 | Re: Using per-transaction memory contexts for storing decoded tuples |