| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Joe Conway <mail(at)joeconway(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, "Guo, Adam" <adamguo(at)amazon(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Jim Mlodgenski <jimmy76(at)gmail(dot)com> |
| Subject: | Re: pg_trgm comparison bug on cross-architecture replication due to different char implementation |
| Date: | 2024-09-16 16:24:30 |
| Message-ID: | 20240916162430.33.nmisch@google.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 12, 2024 at 03:42:48PM -0700, Masahiko Sawada wrote:
> On Tue, Sep 10, 2024 at 3:05 PM Noah Misch <noah(at)leadboat(dot)com> wrote:
> > On Tue, Sep 10, 2024 at 05:56:47PM -0400, Tom Lane wrote:
> > > Got it. So now I'm wondering if we need all the complexity of storing
> > > stuff in the GIN metapages. Could we simply read the (primary's)
> > > signedness out of pg_control and use that?
> I've attached a PoC patch for this idea. We write the default char
> signedness to the control file at initdb time. Then when comparing two
> trgms, pg_trgm opclasses use a comparison function based on the char
> signedness of the cluster. I've confirmed that the patch fixes the
> reported case at least.
I agree that proves the concept.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2024-09-16 17:10:52 | Re: Introduce XID age and inactive timeout based replication slot invalidation |
| Previous Message | Tom Lane | 2024-09-16 15:30:58 | Re: Psql meta-command conninfo+ |