From: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
---|---|
To: | ashutosh(dot)bapat(dot)oss(at)gmail(dot)com |
Cc: | dgrowleyml(at)gmail(dot)com, orlovmg(at)gmail(dot)com, jian(dot)universality(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Add memory/disk usage for WindowAgg nodes in EXPLAIN |
Date: | 2024-09-13 09:31:53 |
Message-ID: | 20240913.183153.727679591062671857.ishii@postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> The patch looks fine but it doesn't add a test case where Storage is
> Disk
We can test the case by setting work_mem to the minimum size (64kB)
and giving slightly larger "stop" parameter to generate_series.
> or the case when the last usage fit in memory but an earlier
> usage spilled to disk.
In my understanding once tuplestore changes the storage type to disk,
it never returns to the memory storage type in terms of
tuplestore_get_stats. i.e. once state->usedDisk is set to true, it
never goes back to false. So the test case is not necessary.
David, am I correct?
> Do we want to cover those. This test would be
> the only one where those code paths could be tested.
I am fine to add the first test case.
Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
From | Date | Subject | |
---|---|---|---|
Next Message | shveta malik | 2024-09-13 09:43:36 | Re: Allow logical failover slots to wait on synchronous replication |
Previous Message | Ashutosh Bapat | 2024-09-13 09:06:41 | Re: Add memory/disk usage for WindowAgg nodes in EXPLAIN |