Re: Add has_large_object_privilege function

On Thu, 12 Sep 2024 19:07:22 +0900
Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:

>
>
> On 2024/09/10 17:45, Yugo NAGATA wrote:
> > On Mon, 9 Sep 2024 22:59:34 +0900
> > Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
> >
> >>
> >>
> >> On 2024/07/02 16:34, Yugo NAGATA wrote:
> >>> So, I would like to propose to add
> >>> has_large_object_function for checking if a user has the privilege on a large
> >>> object.
> >>
> >> +1
> >
> > Thank you for your looking into this!
> > I've attached a updated patch.
>
> Thanks for updating the patches! LGTM, except for a couple of minor things:
>
> +okui chiba * has_largeobject_privilege_id
>
> "okui chiba" seems to be a garbage text accidentally added.
>
> + * role by Oid, large object by id, and privileges as AclMode.
>
> "Oid" seems better than "id" in "large object by id".

Thank you for pointing out it.
I've fixed them and attached the updated patch, v3.

Regards,
Yugo Nagata

--
Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>