From: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
---|---|
To: | ashutosh(dot)bapat(dot)oss(at)gmail(dot)com |
Cc: | dgrowleyml(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Add memory/disk usage for WindowAgg nodes in EXPLAIN |
Date: | 2024-09-06 07:50:30 |
Message-ID: | 20240906.165030.496293122169166261.ishii@postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> The changes look better. A nitpick though. With their definitions
> changed, I think it's better to change the names of the functions
> since their purpose has changed. Right now they report the storage
> type and size used, respectively, at the time of calling the function.
> With this patch, they report maximum space ever used and the storage
> corresponding to the maximum space. tuplestore_space_used() may be
> changed to tuplestore_maxspace_used(). I am having difficulty with
> tuplestore_storage_type_name(); tuplestore_largest_storage_type_name()
> seems mouthful and yet not doing justice to the functionality. It
> might be better to just have one funciton tuplestore_maxspace_used()
> which returns both the maximum space used as well as the storage type
> when maximum space was used.
+1. Returning the storage type by the same function, not by a separate
function looks more natural.
Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Langote | 2024-09-06 08:01:40 | Re: pgsql: Add more SQL/JSON constructor functions |
Previous Message | Richard Guo | 2024-09-06 07:18:57 | Re: Support run-time partition pruning for hash join |