| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Use read streams in pg_visibility |
| Date: | 2024-09-05 15:54:35 |
| Message-ID: | 20240905155435.74.nmisch@google.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 05, 2024 at 03:59:53PM +0300, Nazir Bilal Yavuz wrote:
> On Wed, 4 Sept 2024 at 21:43, Noah Misch <noah(at)leadboat(dot)com> wrote:
> > https://postgr.es/m/CAEudQAozv3wTY5TV2t29JcwPydbmKbiWQkZD42S2OgzdixPMDQ@mail.gmail.com
> > then observed that collect_corrupt_items() was now guaranteed to never detect
> > corruption. I have pushed revert ddfc556 of the pg_visibility.c changes. For
> > the next try, could you add that testing we discussed?
>
> Do you think that corrupting the visibility map and then seeing if
> pg_check_visible() and pg_check_frozen() report something is enough?
I think so. Please check that it would have caught both the blkno bug and the
above bug.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ilia Evdokimov | 2024-09-05 16:05:06 | Adding NOTICE for differences between estimated and actual rows |
| Previous Message | Peter Eisentraut | 2024-09-05 15:51:39 | Re: json_query conditional wrapper bug |