| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Use read streams in pg_visibility |
| Date: | 2024-09-04 18:43:22 |
| Message-ID: | 20240904184322.e2@rfd.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 03, 2024 at 10:46:34PM +0300, Nazir Bilal Yavuz wrote:
> On Tue, 3 Sept 2024 at 22:20, Noah Misch <noah(at)leadboat(dot)com> wrote:
> > On Tue, Sep 03, 2024 at 10:50:11AM -0700, Noah Misch wrote:
> > > Pushed with some other cosmetic changes.
>
> Thanks!
>
> > I see I pushed something unacceptable under ASAN. I will look into that:
> > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=grassquit&dt=2024-09-03%2017%3A47%3A20
>
> I think it is related to the scope of BlockRangeReadStreamPrivate in
> the collect_visibility_data() function. Attached a small fix for that.
Right.
https://postgr.es/m/CAEudQAozv3wTY5TV2t29JcwPydbmKbiWQkZD42S2OgzdixPMDQ@mail.gmail.com
then observed that collect_corrupt_items() was now guaranteed to never detect
corruption. I have pushed revert ddfc556 of the pg_visibility.c changes. For
the next try, could you add that testing we discussed?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2024-09-04 19:03:53 | Re: GetRelationPath() vs critical sections |
| Previous Message | Nathan Bossart | 2024-09-04 18:40:49 | Re: Large expressions in indexes can't be stored (non-TOASTable) |