Re: Buf fix: update-po for PGXS does not work

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: "Ryo Matsumura (Fujitsu)" <matsumura(dot)ryo(at)fujitsu(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Buf fix: update-po for PGXS does not work
Date: 2024-08-21 00:56:54
Message-ID: 202408210056.xo5zv6fyaslf@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2023-Oct-27, Ryo Matsumura (Fujitsu) wrote:

> Hi hackers,
>
> I found that 'make update-po' for PGXS does not work.
> Even if execute 'make update-po', but xx.po.new is not generated.
> I don't test and check for meson build system, but I post it tentatively.
>
> I attached patch and test set.
> 'update-po' tries to find *.po files $top_srcdir, but there is no po-file in PGXS system because $top_srcdir is install directory.

Thanks. I think you have the order of the ifdef nest backwards; even in
the PGXS case we should have "ALL_LANGUAGES = $(AVAIL_LANGUAGES)" unless
we're making update-po. Here I present it the other way around.

Regards

--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"World domination is proceeding according to plan" (Andrew Morton)

Attachment Content-Type Size
v2-0001-fix-update-po-for-the-PGXS-case.patch text/x-diff 1.3 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message px shi 2024-08-21 01:11:03 Re: [Bug Fix]standby may crash when switching-over in certain special cases
Previous Message Alexander Korotkov 2024-08-21 00:17:40 Re: POC, WIP: OR-clause support for indexes