Re: libpq: Fix lots of discrepancies in PQtrace

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: libpq: Fix lots of discrepancies in PQtrace
Date: 2024-08-16 00:05:13
Message-ID: 202408160005.k6pafpzuz5dl@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello,

On 2024-Aug-14, Jelte Fennema-Nio wrote:

> The following removed comments seems useful to keep (I realize I
> already removed them in a previous version of the patch, but I don't
> think I did that on purpose)
> [...]

Ah, yeah, I agree. I put them back, and pushed 0005, 6 and 7 as a
single commit. It didn't seem worth pushing each separately, really. I
added two lines for the CopyData message as well, since otherwise the
output shows the "mismatched length" error when getting COPY data.

I'm leaving 0008 to whoever is doing the NegotiateProtocolVersion stuff;
maybe post that one in that thread you mentioned. I'll mark this CF
entry committed.

Many thanks!

--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2024-08-16 00:35:24 Re: Statistics Import and Export
Previous Message Jacob Champion 2024-08-15 22:39:00 Re: Add new protocol message to change GUCs for usage with future protocol-only GUCs