From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
---|---|
To: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: libpq: Fix lots of discrepancies in PQtrace |
Date: | 2024-08-14 17:37:30 |
Message-ID: | 202408141737.cneamqvnv4l4@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
I gave another look to the remaining patches; here they are again. I
propose some changes:
- to 0005 I change your pqTraceOutputEncryptionRequestResponse()
function name to pqTraceOutputCharResponse and instead of attaching
the "Response" literal in the outpuer to the name given in the
function call, just pass the whole string as argument to the function.
- to 0006 I change function name pqFinishParsingMessage() to
pqParseDone() and reworded the commentary; also moved it to fe-misc.c.
Looks good otherwise.
- 0008 to fix NegotiateProtocolVersion looks correct per [1], but I
don't know how to test it. Suggestions?
I didn't look at 0007.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"No hay hombre que no aspire a la plenitud, es decir,
la suma de experiencias de que un hombre es capaz"
Attachment | Content-Type | Size |
---|---|---|
v3-0005-libpq-Trace-responses-to-SSLRequest-and-GSSENCReq.patch | text/x-diff | 3.7 KB |
v3-0006-libpq-Trace-all-messages-received-from-the-server.patch | text/x-diff | 8.3 KB |
v3-0007-libpq-Trace-server-Authentication-messages-in-det.patch | text/x-diff | 3.0 KB |
v3-0008-libpq-Trace-NegotiateProtocolVersion-correctly.patch | text/x-diff | 1.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Joseph Koshakow | 2024-08-14 17:41:40 | Re: Remove dependence on integer wrapping |
Previous Message | Joel Jacobson | 2024-08-14 17:25:51 | Re: [PATCH] Add get_bytes() and set_bytes() functions |