Re: Use read streams in CREATE DATABASE command when the strategy is wal_log

From: Noah Misch <noah(at)leadboat(dot)com>
To: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Use read streams in CREATE DATABASE command when the strategy is wal_log
Date: 2024-07-20 11:27:18
Message-ID: 20240720112718.68.nmisch@google.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 18, 2024 at 02:11:13PM +0300, Nazir Bilal Yavuz wrote:
> v4 is attached.

Removal of the PinBufferForBlock() comment about the "persistence =
RELPERSISTENCE_PERMANENT" fallback started to feel like a loss. I looked for
a way to re-add a comment about the fallback.
https://coverage.postgresql.org/src/backend/storage/buffer/bufmgr.c.gcov.html
shows no test coverage of that fallback, and I think the fallback is
unreachable. Hence, I've removed the fallback in a separate commit. I've
pushed that and your three patches. Thanks.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2024-07-20 11:28:35 Re: race condition in pg_class
Previous Message Alexander Lakhin 2024-07-20 08:00:00 Re: race condition in pg_class