| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Jeff Davis <pgsql(at)j-davis(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Joe Conway <mail(at)joeconway(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: MAINTAIN privilege -- what do we need to un-revert it? |
| Date: | 2024-07-13 21:47:48 |
| Message-ID: | 20240713214748.cb@rfd.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 12, 2024 at 04:50:17PM -0700, Jeff Davis wrote:
> On Fri, 2024-07-12 at 16:11 -0700, Noah Misch wrote:
> > Since refresh->relation is a RangeVar, this departs from the standard
> > against
> > repeated name lookups, from CVE-2014-0062 (commit 5f17304).
>
> Interesting, thank you.
>
> I did a rough refactor and attached v3. Aside from cleanup issues, is
> this what you had in mind?
> +extern ObjectAddress RefreshMatViewByOid(Oid matviewOid, bool skipData, bool concurrent,
> + const char *queryString, ParamListInfo params,
> + QueryCompletion *qc);
>
Yes, that's an API design that avoids repeated name lookups.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2024-07-13 22:00:32 | Re: tests fail on windows with default git settings |
| Previous Message | Tom Lane | 2024-07-13 17:16:14 | Re: Converting tab-complete.c's else-if chain to a switch |