| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alexander Lakhin <exclusion(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Jeff Davis <pgsql(at)j-davis(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec> |
| Subject: | Re: LogwrtResult contended spinlock |
| Date: | 2024-07-01 17:04:36 |
| Message-ID: | 202407011704.ujh2z5vtmx5d@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2024-Jul-01, Tom Lane wrote:
> Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> > Maybe we can do something like this,
>
> > +#if MAXIMUM_ALIGNOF >= 8
> > uint64 currval;
>
> This should probably be testing the alignment of int64 specifically,
> rather than assuming that MAXIMUM_ALIGNOF applies to it. At least
> historically, there have been platforms where MAXIMUM_ALIGNOF is
> determined by float quantities and integer quantities are different.
OK, so it's
#if ALIGNOF_LONG_LONG_INT >= 8
Alexander, can you please confirm whether this works for you?
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"La virtud es el justo medio entre dos defectos" (Aristóteles)
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Fix-alignment-in-pg_atomic_monotonic_advance_u64.patch | text/x-diff | 2.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2024-07-01 17:15:13 | Re: call for applications: mentoring program for code contributors |
| Previous Message | Nathan Bossart | 2024-07-01 16:51:58 | Re: pg_sequence_last_value() for unlogged sequences on standbys |