Re: pgsql: Skip some permissions checks on Cygwin

From: Noah Misch <noah(at)leadboat(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Skip some permissions checks on Cygwin
Date: 2024-06-24 01:03:11
Message-ID: 20240624010311.0b.nmisch@google.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Thu, Jun 13, 2024 at 12:12:29PM +0000, Andrew Dunstan wrote:
> Skip some permissions checks on Cygwin
>
> These are checks that are already skipped on other Windows systems.

> skip "unix-style permissions not supported on Windows", 2
> - if ($windows_os);
> + if ($windows_os || $Config::Config{osname} eq 'cygwin');

> - skip "group access not supported on Windows", 3 if ($windows_os);
> + skip "group access not supported on Windows", 3
> + if ($windows_os || $Config::Config{osname} eq 'cygwin');

Cygwin does support Unix-style permissions, so I'm not following the rationale
for this change. Can you say more?

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2024-06-24 11:21:23 pgsql: Translation updates
Previous Message Alexander Korotkov 2024-06-22 13:17:55 pgsql: Remove extra comment at TableAmRoutine.scan_analyze_next_block