Re: Using LibPq in TAP tests via FFI

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Using LibPq in TAP tests via FFI
Date: 2024-06-16 23:24:35
Message-ID: 20240616232435.n4p3d6j6nbdnyiku@awork3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2024-06-16 19:07:49 -0400, Tom Lane wrote:
> Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> > On Mon, Jun 17, 2024 at 10:38 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
> >> I'm somewhat doubtful we'll just agree on making FFI::Platypus a hard
> >> dependency, but if we agree to do so...
>
> > Why can't we just do that? I mean, do we have any concrete reason to
> > think that it'll block a supported platform?
>
> IIUC, this would only be a hard dependency if you want to run certain
> TAP tests (maybe eventually all of them).

I think it'd be all of them within a very short timeframe. IMO we'd want to
convert a bunch of the code in Cluster.pm to use psql-less connections to
maximize the benefit across all tests, without needing to modify all of them.

Greetings,

Andres Freund

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2024-06-16 23:27:12 Re: assertion failure at cost_memoize_rescan()
Previous Message Tom Lane 2024-06-16 23:07:49 Re: Using LibPq in TAP tests via FFI