| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Remove distprep |
| Date: | 2024-06-16 19:34:48 |
| Message-ID: | 20240616193448.28@rfd.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Oct 05, 2023 at 05:46:46PM +0200, Peter Eisentraut wrote:
> --- a/src/backend/Makefile
> +++ b/src/backend/Makefile
> $(top_builddir)/src/include/storage/lwlocknames.h: storage/lmgr/lwlocknames.h
> - prereqdir=`cd '$(dir $<)' >/dev/null && pwd` && \
> - cd '$(dir $@)' && rm -f $(notdir $@) && \
> - $(LN_S) "$$prereqdir/$(notdir $<)" .
> + rm -f '$@'
> + $(LN_S) ../../backend/$< '$@'
>
> $(top_builddir)/src/include/utils/wait_event_types.h: utils/activity/wait_event_types.h
> - prereqdir=`cd '$(dir $<)' >/dev/null && pwd` && \
> - cd '$(dir $@)' && rm -f $(notdir $@) && \
> - $(LN_S) "$$prereqdir/$(notdir $<)" .
> + rm -f '$@'
> + $(LN_S) ../../backend/$< '$@'
These broke the
https://www.postgresql.org/docs/17/installation-platform-notes.html#INSTALLATION-NOTES-MINGW
build, where LN_S='cp -pR'. On other platforms, "make LN_S='cp -pR'"
reproduces this. Reverting the above lines fixes things. The buildfarm has
no coverage for that build scenario (fairywren uses Meson).
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2024-06-16 19:59:06 | Re: Remove distprep |
| Previous Message | Pavel Stehule | 2024-06-16 19:18:53 | Re: Schema variables - new implementation for Postgres 15 |