Re: Why does pgindent's README say to download typedefs.list from the buildfarm?

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Why does pgindent's README say to download typedefs.list from the buildfarm?
Date: 2024-05-15 20:28:49
Message-ID: 20240515202849.GB1432094@nathanxps13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, May 15, 2024 at 04:07:18PM -0400, Robert Haas wrote:
> On Wed, May 15, 2024 at 3:30 PM Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>> This is much cleaner, thanks. The only thing that stands out to me is that
>> the "once per release cycle" section should probably say to do an indent
>> run after downloading the typedef file.
>
> How's this?

I compared this with my v1, and the only bit of information there that I
see missing in v3 is that validation step 4 only applies in the
once-per-cycle run (or if you forget to pgindent before committing a
patch). This might be why I was struggling to untangle the two types of
pgindent runs in my attempt. Perhaps it's worth adding a note to that step
about when it is required.

--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2024-05-15 20:48:12 Re: add function argument names to regex* functions.
Previous Message Chapman Flack 2024-05-15 20:28:35 Re: add function argument names to regex* functions.