Re: WAL record CRC calculated incorrectly because of underlying buffer modification

From: Andres Freund <andres(at)anarazel(dot)de>
To: Alexander Lakhin <exclusion(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: WAL record CRC calculated incorrectly because of underlying buffer modification
Date: 2024-05-10 15:57:42
Message-ID: 20240510155742.sznwmnmllsewjsbc@awork3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2024-05-10 16:00:01 +0300, Alexander Lakhin wrote:
> and discovered that XLogRecordAssemble() calculates CRC over a buffer,
> that might be modified by another process.

If, with "might", you mean that it's legitimate for that buffer to be
modified, I don't think so. The bug is that something is modifying the buffer
despite it being exclusively locked.

I.e. what we likely have here is a bug somewhere in the hash index code.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2024-05-10 16:09:15 Re: Fix parallel vacuum buffer usage reporting
Previous Message Nazir Bilal Yavuz 2024-05-10 15:55:27 Re: Fix parallel vacuum buffer usage reporting