| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Andrew Bille <andrewbille(at)gmail(dot)com> |
| Subject: | Re: pg17 issues with not-null contraints |
| Date: | 2024-04-17 17:45:13 |
| Message-ID: | 202404171745.7c7xu2tfpb4w@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2024-Apr-16, Justin Pryzby wrote:
> Yes, this fixes the issue I reported.
Excellent, thanks for confirming.
> BTW, that seems to be the same issue Andrew reported in January.
> https://www.postgresql.org/message-id/CAJnzarwkfRu76_yi3dqVF_WL-MpvT54zMwAxFwJceXdHB76bOA%40mail.gmail.com
That's really good news -- I was worried it would require much more
invasive changes. I tested his case and noticed two additional issues,
first that we fail to acquire locks down the hierarchy, so recursing
down like ATPrepAddPrimaryKey does fails to pin down the children
properly; and second, that the constraint left behind by restoring the
dump preserves the "throaway" name. I made pg_dump use a different name
when the table has a parent, just in case we end up not dropping the
constraint.
I'm going to push this early tomorrow. CI run:
https://cirrus-ci.com/build/5754149453692928
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Fix-restore-of-not-null-constraints-with-inherita.patch | text/x-diff | 18.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kirk Wolak | 2024-04-17 17:47:05 | Idea Feedback: psql \h misses -> Offers Links? |
| Previous Message | Thomas Munro | 2024-04-17 17:42:06 | Re: Solaris tar issues, or other reason why margay fails 010_pg_basebackup? |