| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Egor Chindyaskin <kyzevan23(at)mail(dot)ru>, Sascha Kuhl <yogidabanli(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Stack overflow issue |
| Date: | 2024-04-17 17:35:28 |
| Message-ID: | 20240417173528.257mnitlhncdxx23@awork3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2024-04-17 14:39:14 +0300, Alexander Korotkov wrote:
> On Wed, Apr 17, 2024 at 2:37 PM Alexander Korotkov <aekorotkov(at)gmail(dot)com> wrote:
> > I've invested more time into polishing this. I'm intended to push
> > this. Could you, please, take a look before?
>
> Just after sending this I spotted a typo s/untill/until/. The updated
> version is attached.
Nice, I see you moved the code back to "where it was", the diff to 16 got
smaller this way.
> + /*
> + * Repeatedly call CommitTransactionCommandInternal() until all the work
> + * is done.
> + */
> + while (!CommitTransactionCommandInternal());
Personally I'd use
{
}
instead of just ; here. The above scans weirdly for me. But it's also not
important.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2024-04-17 17:42:06 | Re: Solaris tar issues, or other reason why margay fails 010_pg_basebackup? |
| Previous Message | Andres Freund | 2024-04-17 17:28:03 | Re: documentation structure |