| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Cc: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>, Japin Li <japinli(at)hotmail(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Table AM Interface Enhancements |
| Date: | 2024-04-07 21:40:01 |
| Message-ID: | 20240407214001.jgpg5q3yv33ve6y3@awork3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2024-03-30 23:33:04 +0200, Alexander Korotkov wrote:
> I've pushed 0001, 0002 and 0006.
I briefly looked at 27bc1772fc81 and I don't think the state post this commit
makes sense. Before this commit another block based AM could implement analyze
without much code duplication. Now a large portion of analyze.c has to be
copied, because they can't stop acquire_sample_rows() from calling
heapam_scan_analyze_next_block().
I'm quite certain this will break a few out-of-core AMs in a way that can't
easily be fixed.
And even for non-block based AMs, the new interface basically requires
reimplementing all of analyze.c.
What am I missing here?
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melih Mutlu | 2024-04-07 21:56:56 | Re: Flushing large data immediately in pqcomm |
| Previous Message | Thomas Munro | 2024-04-07 21:36:59 | Re: Streaming read-ready sequential scan code |