Re: pgsql: Use bump memory context for tuplesorts

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Melanie Plageman <melanieplageman(at)gmail(dot)com>, David Rowley <drowley(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Use bump memory context for tuplesorts
Date: 2024-04-07 21:11:14
Message-ID: 20240407211114.mzjkkndh6unhfsi3@awork3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi,

On 2024-04-07 13:52:28 -0400, Tom Lane wrote:
> Melanie Plageman <melanieplageman(at)gmail(dot)com> writes:
> > Looks like this assert is tripping on grison [1].
>
> > running bootstrap script ... TRAP: failed Assert("total_allocated ==
> > context->mem_allocated"), File: "bump.c", Line: 808, PID: 30248
>
> The same on mamba. However, I failed to duplicate it in an x86
> (32-bit) VM. I think the critical factor on the failing machines
> is that MAXALIGN is 8 which is more than their sizeof(pointer).

For posterity: I think the above is correct, and that I found the concrete
reason this causes issues on the thread related to the patch. I posted there
because I figured it out after looking at Tomas' gdb output:

https://postgr.es/m/20240407210924.fvwfwbzms3bvtfcd%40awork3.anarazel.de

- Andres

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2024-04-07 21:16:39 pgsql: Doc: clarify behavior of boolean options in replication protocol
Previous Message Tom Lane 2024-04-07 21:08:22 pgsql: Remove useless duplicate call of defGetBoolean().