Re: [EXTERNAL] Re: Add non-blocking version of PQcancel

On 2024-Apr-03, Tom Lane wrote:

> On my machine, headerscheck does not like this:
>
> $ src/tools/pginclude/headerscheck --cplusplus
> In file included from /tmp/headerscheck.4gTaW5/test.cpp:3:
> ./src/include/libpq/libpq-be-fe-helpers.h: In function 'char* libpqsrv_cancel(PGconn*, TimestampTz)':
> ./src/include/libpq/libpq-be-fe-helpers.h:393:10: warning: ISO C++ forbids converting a string constant to 'char*' [-Wwrite-strings]
> return "out of memory";
> ^~~~~~~~~~~~~~~
> ./src/include/libpq/libpq-be-fe-helpers.h:421:13: warning: ISO C++ forbids converting a string constant to 'char*' [-Wwrite-strings]
> error = "cancel request timed out";
> ^~~~~~~~~~~~~~~~~~~~~~~~~~
>
> The second part of that could easily be fixed by declaring "error" as
> "const char *". As for the first part, can we redefine the whole
> function as returning "const char *"? (If not, this coding is very
> questionable anyway.)

Yeah, this seems to work and I no longer get that complaint from
headerscheck.

--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/