| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | John Naylor <johncnaylorls(at)gmail(dot)com>, Ants Aasma <ants(at)cybertec(dot)at>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: add AVX2 support to simd.h |
| Date: | 2024-03-27 21:37:35 |
| Message-ID: | 20240327213735.GA95234@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 27, 2024 at 05:10:13PM -0400, Tom Lane wrote:
> Shouldn't "i" be declared uint32, since nelem is?
Yes, that's a mistake.
> BTW, I wonder why these functions don't declare their array
> arguments like "const uint32 *base".
They probably should. I don't see any reason not to, and my compiler
doesn't complain, either.
> LGTM otherwise, and I like the fact that the #if structure
> gets a lot less messy.
Thanks for reviewing. I've attached a v2 that I intend to commit when I
get a chance.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-improve-style-of-pg_lfind32.patch | text/x-diff | 3.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2024-03-27 21:52:01 | Re: Streaming I/O, vectored I/O (WIP) |
| Previous Message | Dave Cramer | 2024-03-27 21:33:17 | incorrect results and different plan with 2 very similar queries |