From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, alex work <alexwork033(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
Subject: | Re: Slow GRANT ROLE on PostgreSQL 16 with thousands of ROLEs |
Date: | 2024-03-26 19:49:25 |
Message-ID: | 20240326194925.GB3701353@nathanxps13 |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-general pgsql-hackers |
On Tue, Mar 26, 2024 at 03:08:00PM -0400, Tom Lane wrote:
> My one remaining suggestion is that this comment isn't very precise
> about what's happening:
>
> * If there is a previously-created Bloom filter, use it to determine
> * whether the role is missing from the list. Otherwise, do an ordinary
> * linear search through the existing role list.
>
> Maybe more like
>
> * If there is a previously-created Bloom filter, use it to try to
> * determine whether the role is missing from the list. If it
> * says yes, that's a hard fact and we can go ahead and add the
> * role. If it says no, that's only probabilistic and we'd better
> * search the list. Without a filter, we must always do an ordinary
> * linear search through the existing list.
>
> LGTM other than that nit.
Committed with that change. Thanks for the guidance on this one.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
From | Date | Subject | |
---|---|---|---|
Next Message | Isaac Morland | 2024-03-26 22:22:32 | recovery.signal not being removed when recovery complete |
Previous Message | Tom Lane | 2024-03-26 19:08:00 | Re: Slow GRANT ROLE on PostgreSQL 16 with thousands of ROLEs |
From | Date | Subject | |
---|---|---|---|
Next Message | Bharath Rupireddy | 2024-03-26 19:49:51 | Re: New Table Access Methods for Multi and Single Inserts |
Previous Message | Pavel Stehule | 2024-03-26 19:24:02 | Re: Schema variables - new implementation for Postgres 15 |