Re: pgsql: Allow using syncfs() in frontend utilities.

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Nathan Bossart <nathan(at)postgresql(dot)org>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: Allow using syncfs() in frontend utilities.
Date: 2024-03-26 14:52:10
Message-ID: 20240326145210.GA3181099@nathanxps13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Fri, Mar 22, 2024 at 12:52:15PM -0400, Robert Haas wrote:
> I'd like to complain about this commit's addition of a new appendix. I
> do understand the temptation to document caveats like this centrally
> instead of in multiple places, but as I've been complaining about over
> in the "documentation structure" thread, our top-level documentation
> index is too big, and I feel strongly that we need to de-clutter it
> rather than cluttering it further. This added a new chapter which is
> just 5 sentences long. I understand that this was done because the
> same issue applies to a bunch of different utilities and we didn't
> want to duplicate this text in all of those places, but I feel like
> this approach just doesn't scale. If we did this in every place where
> we have this much text that we want to avoid duplicating, we'd soon
> have hundreds of appendixes.

Sorry I missed this. I explored a couple of options last year but the
discussion trailed off [0].

> What I would suggest we do instead is pick one of the places where
> this comes up and document it there, perhaps the
> recovery_init_sync_method GUC. And then make the documentation for the
> other say something like, you know those issues we documented for
> recovery_init_sync_method? Well they also apply to this.

WFM. I'll put together a patch.

[0] https://postgr.es/m/20231009204823.GA659480%40nathanxps13

--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Nathan Bossart 2024-03-26 15:09:18 Re: pgsql: Track last_inactive_time in pg_replication_slots.
Previous Message Magnus Hagander 2024-03-26 13:09:45 Re: pgsql: make dist uses git archive

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2024-03-26 15:09:18 Re: pgsql: Track last_inactive_time in pg_replication_slots.
Previous Message Tom Lane 2024-03-26 14:35:43 Re: Regression tests fail with musl libc because libpq.so can't be loaded