From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
Cc: | Tristan Partin <tristan(at)neon(dot)tech>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: make dist using git archive |
Date: | 2024-03-26 07:56:32 |
Message-ID: | 20240326075632.mzacnmmympllr3ut@awork3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On 2024-03-26 08:36:58 +0100, Peter Eisentraut wrote:
> On 26.03.24 01:23, Andres Freund wrote:
> > On 2024-03-25 06:44:33 +0100, Peter Eisentraut wrote:
> > > Done and committed.
> >
> > This triggered a new warning for me:
> >
> > ../../../../../home/andres/src/postgresql/meson.build:3422: WARNING: Project targets '>=0.54' but uses feature introduced in '0.55.0': Passing executable/found program object to script parameter of add_dist_script.
>
> Hmm, I don't see that. Is there another version dependency that controls
> when you see version dependency warnings? ;-)
Sometimes an incompatibility is later noticed and a warning is introduced at
that point.
> We could trivially remove this particular line, or perhaps put a
>
> if meson.version().version_compare('>=0.55')
>
> around it. (But would that still warn?)
It shouldn't, no. As long as the code is actually executed within the check,
it avoids the warning. However if you just set a variable inside the version
gated block and then later use the variable outside that, it will
warn. Probably hard to avoid...
Greetings,
Andres Freund
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2024-03-26 07:59:12 | Re: Recent 027_streaming_regress.pl hangs |
Previous Message | Bertrand Drouvot | 2024-03-26 07:45:19 | Re: Introduce XID age and inactive timeout based replication slot invalidation |