Re: pgsql: Clean up role created in new subscription test.

From: Andres Freund <andres(at)anarazel(dot)de>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, vignesh C <vignesh21(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: Clean up role created in new subscription test.
Date: 2024-03-25 18:48:24
Message-ID: 20240325184824.uxbh6o7w4442o4nv@awork3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Hi,

On 2024-01-19 15:40:21 +0100, Peter Eisentraut wrote:
> On 19.01.24 15:26, Daniel Gustafsson wrote:
> > > On 18 Jan 2024, at 01:57, vignesh C <vignesh21(at)gmail(dot)com> wrote:
> >
> > > There are a lot of failures in CFBot at [1] with:
> >
> > > More details of the same are available at [2].
> > > Do we need to clean up the objects leftover for the reported issues in the test?
> >
> > Not really, these should not need cleaning up, and it's quite odd that it only
> > happens on FreeBSD. I need to investigate further so I'll mark this waiting on
> > author in the meantime
>
> Most likely because only the FreeBSD job uses
> ENFORCE_REGRESSION_TEST_NAME_RESTRICTIONS.

I don't think it's that, but that the freebsd task tests the installcheck
equivalent in meson. I haven't checked what your patch is doing, but perhaps
the issue is that it's seeing global objects concurrently created by another
test?

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Jeff Davis 2024-03-25 19:02:47 pgsql: Clarify comment for LogicalTapeSetBlocks().
Previous Message Bertrand Drouvot 2024-03-25 16:49:12 Re: pgsql: Track last_inactive_time in pg_replication_slots.

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2024-03-25 19:16:09 Re: Possibility to disable `ALTER SYSTEM`
Previous Message Robert Haas 2024-03-25 18:45:40 Re: Possibility to disable `ALTER SYSTEM`