| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, alex work <alexwork033(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: Slow GRANT ROLE on PostgreSQL 16 with thousands of ROLEs |
| Date: | 2024-03-25 15:16:47 |
| Message-ID: | 20240325151647.GA2662364@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general pgsql-hackers |
On Mon, Mar 25, 2024 at 11:08:39AM -0400, Tom Lane wrote:
> * The magic constants (crossover list length and bloom filter size)
> need some testing to see if there are better values. They should
> probably be made into named #defines, too. I suspect, with little
> proof, that the bloom filter size isn't particularly critical --- but
> I know we pulled the crossover of 1000 out of thin air, and I have
> no certainty that it's even within an order of magnitude of being a
> good choice.
I'll try to construct a couple of tests to see if we can determine a proper
order of magnitude.
> * Code needs more than zero comments.
Yup.
> * Is it worth trying to make a subroutine, or at least a macro,
> so as not to have 2 copies of the code?
I think so. I'll try that in the next version.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ron Johnson | 2024-03-25 15:38:38 | Re: Is this a buggy behavior? |
| Previous Message | Adrian Klaver | 2024-03-25 15:09:35 | Re: Query on Postgres SQL transaction |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bertrand Drouvot | 2024-03-25 15:16:54 | Re: pgsql: Track last_inactive_time in pg_replication_slots. |
| Previous Message | Robert Haas | 2024-03-25 15:16:35 | Re: [PATCH] plpython function causes server panic |