From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
---|---|
To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
Cc: | Bartosz Chroł <bartosz(dot)chrol(at)handen(dot)pl>, "pgsql-general(at)postgresql(dot)org" <pgsql-general(at)postgresql(dot)org> |
Subject: | Re: pg_dumpall with flag --no-role-passwords omits roles comments as well |
Date: | 2024-03-21 12:28:56 |
Message-ID: | 202403211228.4szqmhopsskk@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-general |
On 2024-Mar-21, Daniel Gustafsson wrote:
> Comments on roles are stored against the pg_authid catalog relation which is
> the catalog used for dumping roles, but when using --no-role-passwords we
> instead switch to using the pg_roles catalog relation. Since comments are
> dumped for the relations which are dumped, this means that the comments on
> roles are omitted when --no-role-passwords is used.
>
> It's not clear whether that was intentional or not, I'm failing to find the
> thread where it was discussed on a quick mailing list search.
I very much doubt that they realized that comments were going to be
omitted. But clearly it's just a mistake, and easily fixed.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"After a quick R of TFM, all I can say is HOLY CR** THAT IS COOL! PostgreSQL was
amazing when I first started using it at 7.2, and I'm continually astounded by
learning new features and techniques made available by the continuing work of
the development team."
Berend Tober, http://archives.postgresql.org/pgsql-hackers/2007-08/msg01009.php
Attachment | Content-Type | Size |
---|---|---|
v1-0001-fix-dump-of-role-comments-with-no-role-passwords.patch | text/x-diff | 2.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Gustafsson | 2024-03-21 12:32:49 | Re: pg_dumpall with flag --no-role-passwords omits roles comments as well |
Previous Message | veem v | 2024-03-21 12:16:49 | Re: Not able to purge partition |