| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Euler Taveira <euler(at)eulerto(dot)com> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Greg Sabino Mullane <htamfids(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Avoiding inadvertent debugging mode for pgbench |
| Date: | 2024-03-11 15:59:36 |
| Message-ID: | 202403111559.2ot5bbotwcgz@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2024-Mar-01, Euler Taveira wrote:
> I don't like to break backward compatibility but in this case I suspect that it
> is ok. I don't recall the last time I saw a script that makes use of -d option.
> How often do you need a pgbench debug information?
I wondered what the difference actually is, so I checked. In -i mode,
the only difference is that if the tables don't exist before hand, we
receive the NOTICE that it doesn't. In normal mode, the -d switch emits
so much junk that I would believe if somebody told me that passing -d
distorted the benchmark results; and it's hard to believe that such
output is valuable for anything other than debugging pgbench itself.
All in all, I support the original patch.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"I love the Postgres community. It's all about doing things _properly_. :-)"
(David Garamond)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melanie Plageman | 2024-03-11 16:15:44 | Re: Confine vacuum skip logic to lazy_scan_skip |
| Previous Message | Jelte Fennema-Nio | 2024-03-11 15:56:23 | Re: UUID v7 |