From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
---|---|
To: | Alexander Lakhin <exclusion(at)gmail(dot)com> |
Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Noah Misch <noah(at)leadboat(dot)com> |
Subject: | Re: postgres_fdw test timeouts |
Date: | 2024-03-09 14:24:40 |
Message-ID: | 20240309142440.GA1111406@nathanxps13 |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, Mar 09, 2024 at 10:00:00AM +0300, Alexander Lakhin wrote:
> I have re-run the tests and found out that the issue was fixed by
> d3c5f37dd. It changed the inner of the loop "while (PQisBusy(conn))",
> formerly contained in pgfdw_get_result() as follows:
> /* Data available in socket? */
> if (wc & WL_SOCKET_READABLE)
> {
> if (!PQconsumeInput(conn))
> pgfdw_report_error(ERROR, NULL, conn, false, query);
> }
> ->
> /* Consume whatever data is available from the socket */
> if (PQconsumeInput(conn) == 0)
> {
> /* trouble; expect PQgetResult() to return NULL */
> break;
> }
>
> That is, the unconditional "if PQconsumeInput() ..." eliminates the test
> timeout.
Thanks for confirming! I'm assuming this just masks the underlying
issue...
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2024-03-09 14:38:00 | Re: May be BUG. Periodic burst growth of the checkpoint_req counter on replica. |
Previous Message | Alena Rybakina | 2024-03-09 13:24:25 | Re: Support "Right Semi Join" plan shapes |