| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | bt23nguyent <bt23nguyent(at)oss(dot)nttdata(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Improve the log message output of basic_archive when basic_archive.archive_directory parameter is not set |
| Date: | 2024-03-04 21:50:48 |
| Message-ID: | 20240304215048.GA3367383@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 04, 2024 at 09:27:23PM +0100, Daniel Gustafsson wrote:
> Looks good from a read-through, I like it. A few comments on the commit
> message only:
>
> actionable details about the source of the miconfiguration. This
> s/miconfiguration/misconfiguration/
I reworded the commit message a bit to avoid the word "misconfiguration,"
as it felt a bit misleading to me. In any case, this was fixed, albeit
indirectly.
> Reviewed-by: Daniel Gustafsson, ¡lvaro Herrera
> Alvaro's name seems wrong.
Hm. It looks alright to me. I copied the name from his e-mail signature,
which has an accent over the first 'A'. I assume that's why it's not
showing up correctly in some places.
Anyway, I've committed this now. Thanks for taking a look!
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Banck | 2024-03-04 21:58:03 | Re: [PATCH] Exponential backoff for auth_delay |
| Previous Message | Amonson, Paul D | 2024-03-04 21:39:36 | RE: Popcount optimization using AVX512 |